Approving

Learn the flow to approve a PR.

Approving a Pull Request

After reviewing a Pull Request, you can approve it if you consider the changes acceptable. On GitHub, this is done using the Approve option, and the review result is recorded on the PR.

Review status: Approved
Pull Request: #24

Approval indicates that the reviewer considers the current changes acceptable. However, it does not merge the PR by itself.

The relationship between approval and merging

An approved Pull Request is an important step toward being ready for merging. However, the project may have branch protection rules or additional review requirements.

Review: Approved
Status: Ready for merge

Once the required reviews are complete, an authorized person can merge the PR. Approving and merging are separate actions.

Exercise Create an approval result

Create a pullRequest object. Set number to 32, review to "approved", and mergeReady to true. Then print the review status.

Show example solution

const pullRequest = {
    number: 32,
    review: "approved",
    mergeReady: true
};

console.log(pullRequest.review);

Test yourself

Which action is selected to give a positive review to a PR on GitHub?
- Delete branch
- Request changes
- Close pull request
- Approve
Show answer

Approve — The Approve option indicates that the reviewer accepts the current changes.

Record the approval status

const review = {
    reviewer: "Alex",
    status: "____"
};

Show answer

const review = {
    reviewer: "Alex",
    status: "approved"
};

Approval workflow

Review

Examine the changes
Approve

Submit a positive review
Approved

An approved status
Merge ready

Ready to be merged

Next lesson: Summary - Code review

We Are Enhancing Your Experience

Cookie Preferences

Strictly Necessary Cookies

Analytical Cookies