Reviewing a PR
- Git course
- Intermediate
- Lesson 51/82
- 4 min
Learn to review a PR and add comments.
The PR review screen
The Files changed tab of an open GitHub PR displays file changes between the source and target branches. Reviewers can inspect added, removed, or modified lines. Reviewing changes helps identify bugs and opportunities for improvement before merging.
+ const username = "Ada";
- const username = "Guest";A PR review can focus not only on whether the code works but also on readability and maintainability.
Comments and approval
A reviewer can comment on a specific code line to suggest an improvement or report a problem. General PR comments can also be shared from the Conversation section. A reviewer who finds the changes acceptable can approve them using the Approve option in the Review changes menu.
Review changes
Comment
Approve
Request changesRequest changes indicates that some issues should be fixed before merging, while Approve means the reviewer considers the changes acceptable.
Practice Submit a PR review decision
Write the GitHub review decision indicating that you consider the changes acceptable. Then add a short comment to provide feedback to the developer.
Starter code
# İnceleme kararı
# Geri bildirimSample solution
# İnceleme kararı
Approve
# Geri bildirim
Comment: The changes look good.Expected output
Approve Comment: The changes look good.
Questions and answers
Review the lesson questions together with their answers. To test yourself, solve the lesson interactively.
1 Which tab is used to inspect file changes in a PR?
- Settings
- Insights
- Actions
- Files changed Correct answer
Explanation: The Files changed tab displays the line and file changes included in the PR.
2 Approve the review
Review changes
____Review changes
ApproveExplanation: The Approve option indicates that the reviewer considers the PR changes acceptable.
3 Review options
| Term | Meaning |
|---|---|
Comment |
Shares feedback |
Approve |
Approves the changes |
Request changes |
Requests corrections |
Files changed |
Displays file differences |