Summary - Code review

Combine the review flow to approve and merge a PR.

Combine the review workflow

Reviewing a Pull Request, adding inline comments, and approving changes are connected steps. First, you evaluate the code and leave feedback on the lines where necessary.

Review changes
Add inline comments
Approve Pull Request
Merge Pull Request

Once the review is complete and the required approvals are obtained, the PR can be merged.

Exercise Complete the PR review

Create a pullRequest object. Set comment to "Add input validation", review to "approved", and status to "merged". Finally, print the merge status using console.log.

Show example solution

const pullRequest = {
    comment: "Add input validation",
    review: "approved",
    status: "merged"
};

console.log(pullRequest.status);

Test yourself

What is the next action after the review is complete and the required approvals are obtained?
- Clone the repository again
- Merge the PR
- Delete all commits
- Create a new GitHub account
Show answer

Merge the PR — Once the required reviews and approvals are complete, the Pull Request can be merged.

Combine the review result

const pullRequest = {
    comment: "Looks good",
    review: "approved",
    status: "____"
};

Show answer

const pullRequest = {
    comment: "Looks good",
    review: "approved",
    status: "merge_ready"
};

Actions in the review process

Review

Inspect code changes
Comment

Add line feedback
Approve

Accept the changes
Merge

Integrate PR changes

Next lesson: What is an issue?

We Are Enhancing Your Experience

Cookie Preferences

Strictly Necessary Cookies

Analytical Cookies